https://gitlab.synchro.net/main/sbbs/-/commit/b795545afa5e0cc6250e0fb2
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
This is C++ now, value-initialize since we can't zero-initialize

Same-same, but different, but still same.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/83252750de3b2354f2039a18
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
Log better errors/warnings when upload directory doesn't exist

or doesn't have enough free space

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/815458f875915bbb4cfb2b18
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
s/Unallowed/Disallowed

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9d440000f790304469d309db
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
load file data from filebase when updating (uploading) an existing file

updatefile() assumes the file was already loaded. If it was not, you would get an error updating the file, e.g.
ftp 3220 <Guest> !DATA ERROR -101 updating file (filename.txt) in database

Log the restart offset both when the client sets it (with the "REST" command) and in the "uploading" log message, helpful in debugging unique upload issues.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cd30db7872f8ad631aabc16f
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
Case insensitive file-existence check before allowing upload

The Synchronet filebases are index-searched case-insensitively, so don't allow a dupe file (only differing in case) to be uploaded.

This would have already been disallowed/prevented on Windows, but not case sensitive file systems (e.g. *nix).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/16a9d6c01d1a25c8158210ed
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
More accurate log/response messages about maximum file size allowed

The max file size allowed for upload can change based on available disk space and the sysop-configured minimum amount of free disk space. Report the correct numbers.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bb760f2009bfc0b46c250c05
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
Fix the delete permissions flags in the MLST/MLSD support

In commit d4deb4b3, the 'R' and 'D' restrictions were conflated.

I just notice this in code review: the 'D' restriction has nothing to do with removing/deleting files.

Also, a non-R-restricted user can delete any files they've uploaded.
Fixed that too.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f28f210b217239031baa9af1
Modified Files:
src/sbbs3/ftpsrvr.cpp
Log Message:
sbbs3 ftpsrvr: modernize legacy BOOL/TRUE/FALSE to bool/true/false

Mechanical conversion across the file: function signatures, local
variables (incl. volatile flags shared across xfer threads), xfer_t
struct fields, and all literal arguments/comparisons. External callees (load_cfg, matchuser, getnodedat, wildmatchi, seteuid callback) already
declare bool parameters, so no ABI change. Also collapse direxist()'s
if/else to a single return.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net