https://gitlab.synchro.net/main/sbbs/-/commit/cd40697ea4b56cf0066a32f8
Added Files:
src/doors/syncretro/syncretro_statekey.c syncretro_statekey.h
Modified Files:
src/doors/syncretro/CMakeLists.txt syncretro_state.c syncretro_state.h test_statekey.c
Log Message:
syncretro: split sr_state_key() into its own translation unit
sr_state_key() is never called anywhere in the door -- the lobby computes
the state key in JS and hands the door a ready-made key on the command
line, so the only caller is test_statekey.c. Linking md5.c into the door
purely to satisfy that dead function pulled in a GCC false-positive -Wstringop-overread from MD5Transform() (three levels of inlining lose the
loop guard that makes the flagged read unreachable).
Move sr_state_key() out of syncretro_state.c/.h into a new syncretro_statekey.c/.h pair that only the state-key test links, keeping
md5.c (and the warning) out of the door binary entirely.
syncretro_state.c/.h keep sr_state_path()/sr_state_save()/sr_state_load(), which the door does use.
Co-Authored-By: Claude Opus 5 (1M context) <
noreply@anthropic.com>
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net