https://gitlab.synchro.net/main/sbbs/-/commit/bb233b89b205ae98af9eacb6
Modified Files:
src/conio/cterm.c
Log Message:
Continue fixing a coverity issue.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1e9dcf477a5de94298f9bb74
Modified Files:
src/conio/cterm.c
Log Message:
Clamp sixel repeat to 0x7fff per specification.

This is the issue behind CVE-2022-24130 in xterm.
Reported against SyncTERM by Autumn Lamonte (Thanks!)
Discussion here: https://gitlab.com/klamonte/jexer/-/issues/105

Closes SyncTERM bug 79.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5c12fc2e5c7362a36fd68c23
Modified Files:
src/conio/cterm.c
Log Message:
Fix memory leak and uninitialized acces in sixel graphics.

Properly initialize sixel mask width/height.
Free sx_mask->bits when finished.

These were broken by the PPM feature commit 4975b41

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cda7525d78b0948996c19561
Modified Files:
src/conio/cterm.c
Log Message:
Fix off-by-one in delete lines

Previously, delete lines would erase the line above the current one.
This was visible in vim which makes extensive use of delete line
to scroll.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e5c75c3a8268961c2552edb9
Modified Files:
src/conio/cterm.c
Log Message:
Add comments to hopefully shut up Coverity

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/80379e9161895f4241bc30f3
Modified Files:
src/conio/cterm.c
Log Message:
Fix warning: `end' may be used uninitialized in this function

Fix multiple warning: ignoring return value of `asprintf'
declared with attribute `warn_unused_result'

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1181333075e9674aad79ff3e
Modified Files:
src/conio/cterm.c
Log Message:
Fix for 80379e916

The commit just the zero-length behaviour from uninitialized use
with possible undefined behaviour to guaranteed undefined behaviour.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2f436df7f1606aa07ca81b1a
Modified Files:
src/conio/cterm.c
Log Message:
Fix macro recusion protection for macros 32-63.

Found by MSVC

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6621c97c34e6e1f193e45bb3
Modified Files:
src/conio/cterm.c
Log Message:
Disable MSVC warnings 4244 and 4267.

The alternative is to explicitly copy/paste the type everywhere
forcing the compiler to do the only thing it could possibly do,
and making it painful to change a type later.

Honestly, in my opinion, these warnings should just be disabled
completely everywhere.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/21c6201278ed7f0b9ee5f45e
Modified Files:
src/conio/cterm.c
Log Message:
Fix doorway mode.

CSI=255h was not entering doorway mode anymore.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/dc2b586763a0c4a1be105efa
Modified Files:
src/conio/cterm.c
Log Message:
Use default instead of enum value in warning suppression.

This will hopefully keep both Coverity and compilers happy.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/28bfe4a1424f57bb6abf2f8a
Modified Files:
src/conio/cterm.c
Log Message:
When ANSI Music is enabled, CSI M with parameters is still delete line

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f209a29da73cb1da1bc7b4bf
Modified Files:
src/conio/cterm.c
Log Message:
Bump revision.

I need to document when I should do this better.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e8c6145d3d975d6157ec772d
Modified Files:
src/conio/cterm.c
Log Message:
Implement line editing support.

Changing "stuff" on a line will now propogate to the right
appropriately.

Next up is double-height characters... hopefully.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/252e539cc03a4411e4b52897
Modified Files:
src/conio/cterm.c
Log Message:
"Handle" malloc() failures

Just scream on stderr, and screw things up in the window.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76bf7cde63a9a19dfdb75034
Modified Files:
src/conio/cterm.c
Log Message:
Make the default Prestel ID 0 bytes long.

CCl4 sends an ENQ character in the login screen, and sends an ENQ
which will auto-fill your username. Also, if you enter six zeros
into the username, it will take you to the password field.

With ten zeros, this means it's impossible to log in to CCl4.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ab3cfcb1eb84576fe44740f
Modified Files:
src/conio/cterm.c
Log Message:
Fix up the Prestel "Engineering Test Page" rendering

This was due to two main bugs... the simple one was a type where
the cutoff between separated and contiguous mosaics was incorrect,
which caused the first four separated mosaics to not be displayed.

The second was due to a number of bugs in the Hold Mosaic
implementation.

This fixes the first half of issue 172.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/548763fda45f0d0db2bda11b
Modified Files:
src/conio/cterm.c
Log Message:
The final fixings for issue 172

Use 0 for "no held mosaic" to avoid confusion around printable bytes.
Store the state of the current cell *before* updating in fix_line()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net